feat: ESLTogglable based focus management (UPDATED v2) #2753
+170
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focus control based on new focusBehaviour property and utilizes keyboard events to handle flow. New `$focusables` property available for `ESLToggleable` out of the box.
… manager, now utilizes ESLToggleable features BREAKING-CHANGE: `hasFocusLoop` no longer available use `focusBehaviour` instead
…ltip` BREAKING-CHANGE: `ESLSharePopup` no longer inherits `ESLTooltip`, `ESLPopup` now direct base for `ESLSharePopup`
ala-n
requested review from
yadamskaya,
abarmina and
fshovchko
and removed request for
a team
NastaLeo
reviewed
Nov 8, 2024
NastaLeo
approved these changes
Nov 8, 2024
…t boundary focus actions across different options
BREAKING-CHANGE: 'autofocus' no longer available for popup, use 'focus-behaviour' instead
…popup base state)
…l-popup base state)
feat(esl-toggleale/esl-popup): focus management cleanup (v2)
ala-n
changed the title
|
Note for @exadel-inc/esl-core-maintainers : the commit messages are aligned and approved for change log as it is (yeah there are a lot of points to changelog, and that's fine) |
yadamskaya
approved these changes
Nov 14, 2024
dshovchko
approved these changes
Nov 14, 2024
NastaLeo
approved these changes
Nov 14, 2024
abarmina
approved these changes
Nov 14, 2024
fshovchko
approved these changes
Nov 14, 2024
Co-authored-by: Dmytro Shovchko <d.shovchko@gmail.com>
…ement # Conflicts: # src/modules/esl-tooltip/core/esl-tooltip.ts # src/modules/esl-utils/dom/focus.ts
ala-n
force-pushed
the
feat/focus-management
branch
from
1b4b34f
to
1f072c6
Compare
ala-n
force-pushed
the
feat/focus-management
branch
from
1f072c6
to
cf1ed1b
Compare
|
@exadel-inc/esl-all-contributors please note of major fixes happened here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.